JunRuiLee commented on code in PR #23085:
URL: https://github.com/apache/flink/pull/23085#discussion_r1280227631
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java:
##########
@@ -1693,6 +1723,10 @@ public JobGraph createGraphWithMultipleInputs(boolean
chain, String... inputName
transform.setChainingStrategy(
chain ? ChainingStrategy.HEAD_WITH_SOURCES :
ChainingStrategy.NEVER);
+ DataStream<Long> dataStream = new DataStream<>(env, transform);
+ // do not chain with sink operator.
+ dataStream.rebalance().addSink(new DiscardingSink<>()).name(sinkName);
Review Comment:
The way it is written here should be fine and achieves the same effect as
mentioned in the comment. So I ignored this comment.
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java:
##########
@@ -1693,6 +1723,10 @@ public JobGraph createGraphWithMultipleInputs(boolean
chain, String... inputName
transform.setChainingStrategy(
chain ? ChainingStrategy.HEAD_WITH_SOURCES :
ChainingStrategy.NEVER);
+ DataStream<Long> dataStream = new DataStream<>(env, transform);
+ // do not chain with sink operator.
+ dataStream.rebalance().addSink(new DiscardingSink<>()).name(sinkName);
Review Comment:
The way it is written here should be fine and achieves the same effect as
mentioned in the comment. So I ignored this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
