JunRuiLee commented on code in PR #23085:
URL: https://github.com/apache/flink/pull/23085#discussion_r1280229513
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java:
##########
@@ -1655,28 +1655,58 @@ void
testSlotSharingResourceConfigurationWithDefaultSlotSharingGroup() {
@Test
void testNamingOfChainedMultipleInputs() {
String[] sources = new String[] {"source-1", "source-2", "source-3"};
- JobGraph graph = createGraphWithMultipleInputs(true, sources);
- JobVertex head =
graph.getVerticesSortedTopologicallyFromSources().iterator().next();
- assertThat(sources).allMatch(source ->
head.getOperatorPrettyName().contains(source));
+ String sink = "sink";
+ JobGraph graph = createGraphWithMultipleInputs(true, sink, sources);
+ Iterator<JobVertex> iterator =
graph.getVerticesSortedTopologicallyFromSources().iterator();
+
+ JobVertex multipleVertex = iterator.next();
+ verifyJobVertexName(multipleVertex, sources, new String[] {sink});
Review Comment:
done
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java:
##########
@@ -896,12 +896,13 @@ private String createChainedName(
Integer vertexID,
List<StreamEdge> chainedOutputs,
Optional<OperatorChainInfo> operatorChainInfo) {
+ List<ChainedSourceInfo> list =
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
