Fanoid commented on code in PR #248:
URL: https://github.com/apache/flink-ml/pull/248#discussion_r1282923826
##########
flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/datacache/nonkeyed/ListStateWithCache.java:
##########
@@ -82,11 +82,13 @@ public ListStateWithCache(
runtimeContext.getUserCodeClassLoader());
if (fraction > 0) {
MemoryManager memoryManager =
containingTask.getEnvironment().getMemoryManager();
+ // TODO Adds a configuration to set the fraction of the memory
that the
+ // ListStateWithCache can use.
segmentPool =
new LazyMemorySegmentPool(
containingTask,
memoryManager,
- memoryManager.computeNumberOfPages(fraction));
+ memoryManager.computeNumberOfPages(fraction) / 2);
Review Comment:
The changes are acceptable to me. Thank you for your efforts in improving
them!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
