XComp commented on PR #22341: URL: https://github.com/apache/flink/pull/22341#issuecomment-1663693669
Another feedback on reviews: You don't need to squash all the commits together while the review is ongoing. Usually it helps the reviewer to see the individual changes per commit (e.g. a new commit after a review shows the changes based on the review). Squashing everything together makes us lose this information. As a consequence, the reviewer might have to go over already reviewed code changes again. You can collect all the changes in one diff still without having them squashed into a single commit through git. Therefore, squashing the commits into a single one doesn't bring any value as far as I can see. ...just as a hint for future changes. :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
