leonardBang commented on code in PR #23079:
URL: https://github.com/apache/flink/pull/23079#discussion_r1286118566
##########
flink-examples/flink-examples-streaming/pom.xml:
##########
@@ -341,6 +343,19 @@ under the License.
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
<executions>
+ <execution>
+ <phase>package</phase>
Review Comment:
Shading `data-gen` connector to flink-examples-streaming is necessary and
it makes sense to me. minor: We can add a meaningful `<id>` to describe the
shade purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
