Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86106025
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraCommitter.java
---
@@ -118,16 +117,32 @@ public void close() throws Exception {
}
@Override
- public void commitCheckpoint(long checkpointID) {
- session.execute(updateStatement.bind(checkpointID));
- this.lastCommittedCheckpointID = checkpointID;
+ public void commitCheckpoint(int subtaskIdx, long checkpointId) {
+ String statement = String.format(
+ "UPDATE %s.%s set checkpoint_id=%d where sink_id='%s'
and sub_id=%d;",
+ keySpace, table, checkpointId, operatorId, subtaskIdx);
+
+ session.execute(statement);
}
@Override
- public boolean isCheckpointCommitted(long checkpointID) {
- if (this.lastCommittedCheckpointID == -1) {
- this.lastCommittedCheckpointID =
session.execute(selectStatement.bind()).one().getLong("checkpoint_id");
+ public boolean isCheckpointCommitted(int subtaskIdx, long checkpointId)
{
+
+ // Pending checkpointed buffers are committed in ascending
order of their
+ // checkpoint id. This way we can tell if a checkpointed buffer
was committed
+ // just by asking the third party storage system for the last
checkpointed
+ // checkpoint id committed by the specific subtask.
+
+ Long lastCommittedCheckpoint =
lastCommittedCheckpoints.get(subtaskIdx);
+ if (lastCommittedCheckpoint == null || lastCommittedCheckpoint
== -1) {
--- End diff --
we don't need to put -1 into the Map in case no checkpoint was committed;
the map returning null serves the same purpose.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
