Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2707#discussion_r86110136
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/GenericWriteAheadSink.java
---
@@ -57,18 +59,25 @@
private static final long serialVersionUID = 1L;
protected static final Logger LOG =
LoggerFactory.getLogger(GenericWriteAheadSink.class);
+
+ private final String id;
private final CheckpointCommitter committer;
- private transient CheckpointStreamFactory.CheckpointStateOutputStream
out;
protected final TypeSerializer<IN> serializer;
- private final String id;
+
+ private transient CheckpointStreamFactory.CheckpointStateOutputStream
out;
private transient CheckpointStreamFactory checkpointStreamFactory;
- private ExactlyOnceState state = new ExactlyOnceState();
+ private final TreeMap<PendingCheckpointId, PendingHandle>
pendingHandles = new TreeMap<>();
--- End diff --
the `PendingCheckpointId` and `PendingHandle` can be consolidated into a
single object, since they are always used in conjunction, and stored in a
TreeSet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
