[
https://issues.apache.org/jira/browse/FLINK-32866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17754511#comment-17754511
]
Rui Fan commented on FLINK-32866:
---------------------------------
Hi [~mapohl] , thanks for the update.
{quote}A single location for this configuration would be nice
{quote}
I think it's a great solution if we want to enable {{TestLoggerExtension }}for
all tests of the whole flink repo. And I found a good place for it, we can put
it in the same module as TestLoggerExtension.
It means all test classes will enable TestLoggerExtension if the module can
find the TestLoggerExtension class. I have tried it, it works. You can take a
look the draft PR: https://github.com/apache/flink/pull/23217
> Clean up the `@ExtendWith(TestLoggerExtension.class)` for modules that added
> the `TestLoggerExtension` to the `org.junit.jupiter.api.extension.Extension
> resource` file
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-32866
> URL: https://issues.apache.org/jira/browse/FLINK-32866
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: Rui Fan
> Assignee: Rui Fan
> Priority: Minor
> Labels: pull-request-available, starter
>
> Some modules added the {{TestLoggerExtension}} to the
> {{org.junit.jupiter.api.extension.Extension}} resource file. All test classes
> of these modules don't need add the
> {{@ExtendWith(TestLoggerExtension.class)}} at class level.
> This JIRA propose clean up the {{@ExtendWith(TestLoggerExtension.class)}}
> for modules that added the {{TestLoggerExtension}} to the
> {{org.junit.jupiter.api.extension.Extension}} resource file.
> Update: We could also investigate in what extend we could remove the
> {{org.junit.jupiter.api.extension.Extension}} resource files from certain
> modules. It only has to be present once on the classpath. A single location
> for this configuration would be nice (e.g. putting it in
> {{flink-test-utils-parent/flink-test-utils-junit}}). But I think not all
> modules have this one as there dependency. So, having a single resource file
> for configuring this might be not possible. But at least, we can reduce the
> number of files to a minimum.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
