zentol commented on code in PR #23195:
URL: https://github.com/apache/flink/pull/23195#discussion_r1294770709
##########
tools/ci/maven-utils.sh:
##########
@@ -21,12 +21,10 @@ function run_mvn {
MVN_CMD="${M2_HOME}/bin/mvn"
fi
- ARGS=$@
- INVOCATION="$MVN_CMD $MVN_GLOBAL_OPTIONS $ARGS"
if [[ "$MVN_RUN_VERBOSE" != "false" ]]; then
- echo "Invoking mvn with '$INVOCATION'"
+ echo "Invoking mvn with '$MVN_GLOBAL_OPTIONS ${@}'"
Review Comment:
> What are the costs?
The cost is `$MVN_GLOBAL_OPTIONS ${@}` being duplicated in the code.
> Is there a Jira issue for the "1.19 work"?
There is https://issues.apache.org/jira/browse/FLINK-32181, although it
lacks a subtasks for this specific item.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
