XComp commented on code in PR #23195:
URL: https://github.com/apache/flink/pull/23195#discussion_r1294822852
##########
tools/ci/verify_bundled_optional.sh:
##########
@@ -19,22 +19,16 @@
## Checks that all bundled dependencies are marked as optional in the poms
MVN_CLEAN_COMPILE_OUT=$1
-CI_DIR=$2
-FLINK_ROOT=$3
-source "${CI_DIR}/maven-utils.sh"
+MVN=${MVN:-./mvnw}
-cd "$FLINK_ROOT" || exit
+dependency_plugin_output=/tmp/optional_dep.txt
-dependency_plugin_output=${CI_DIR}/optional_dep.txt
-
-run_mvn dependency:tree -B > "${dependency_plugin_output}"
+$MVN dependency:tree -B > "${dependency_plugin_output}"
cat "${dependency_plugin_output}"
-cd "${CI_DIR}/flink-ci-tools/" || exit
-
-run_mvn exec:java
-Dexec.mainClass=org.apache.flink.tools.ci.optional.ShadeOptionalChecker
-Dexec.args=\""${MVN_CLEAN_COMPILE_OUT}" "${dependency_plugin_output}"\"
+$MVN -pl tools/ci/flink-ci-tools exec:java
-Dexec.mainClass=org.apache.flink.tools.ci.optional.ShadeOptionalChecker
-Dexec.args="${MVN_CLEAN_COMPILE_OUT} ${dependency_plugin_output}"
EXIT_CODE=$?
if [ $EXIT_CODE != 0 ]; then
Review Comment:
For me, I'm confronted with the following output when running the
`tools/ci/compile.sh` locally:
```
[INFO] --- exec-maven-plugin:3.1.0:java (default-cli) @ flink-ci-tools ---
16:18:36,976 DEBUG org.apache.flink.tools.ci.optional.ShadeOptionalChecker
[] - Checking module 'flink-parent'.
16:18:36,980 DEBUG org.apache.flink.tools.ci.optional.ShadeOptionalChecker
[] - Module is not bundling any dependencies.
16:18:36,980 INFO org.apache.flink.tools.ci.optional.ShadeOptionalChecker
[] - OK: flink-parent
16:18:36,980 DEBUG org.apache.flink.tools.ci.optional.ShadeOptionalChecker
[] - Checking module 'flink-dstl'.
[WARNING]
java.lang.IllegalStateException: Module flink-dstl listed by shade-plugin,
but not dependency-plugin.
at
org.apache.flink.tools.ci.optional.ShadeOptionalChecker.checkOptionalFlags
(ShadeOptionalChecker.java:134)
at org.apache.flink.tools.ci.optional.ShadeOptionalChecker.main
(ShadeOptionalChecker.java:85)
at org.codehaus.mojo.exec.ExecJavaMojo$1.run (ExecJavaMojo.java:279)
at java.lang.Thread.run (Thread.java:750)
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 6.029 s (Wall Clock)
[INFO] Finished at: 2023-08-15T16:18:36+02:00
[INFO]
------------------------------------------------------------------------
[WARNING] The requested profile "skip-webui-build" could not be activated
because it does not exist.
[ERROR] Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:3.1.0:java (default-cli) on project
flink-ci-tools: An exception occurred while executing the Java class. Module
flink-dstl listed by shade-plugin, but not dependency-plugin. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
==============================================================================
Optional Check failed. See previous output for details.
==============================================================================
```
If I want to verify manually where the error comes from, I have to go
through the logs. AFAIU, this output is actually not the usual script output
but an unexpected error, huh? That would be a reason to go with your
argument... :thinking: I'm gonna investigate it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
