Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295829685
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerITCase.java:
##########
@@ -189,15 +189,13 @@ public void parallelChannelsTest() throws Exception {
try {
intValue = Integer.parseInt(val.value);
} catch (NumberFormatException nfex) {
- Assert.fail(
- "Invalid value read from reader. Valid
decimal number expected.");
+ fail("Invalid value read from reader. Valid
decimal number expected.");
Review Comment:
I think we cannot use `assertThatThrownBy ` here.
It seems that this exception should not occur in this case, maybe we should
use `assertThatNoException` here.
Shall we make that change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
