Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295841032
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterDelegateTest.java:
##########
@@ -137,17 +134,17 @@ private RecordWriter createRecordWriter(NetworkBufferPool
globalPool) throws Exc
private void verifyAvailability(RecordWriterDelegate writerDelegate)
throws Exception {
// writer is available at the beginning
- assertTrue(writerDelegate.isAvailable());
- assertTrue(writerDelegate.getAvailableFuture().isDone());
+ assertThat(writerDelegate.isAvailable()).isTrue();
+ assertThat(writerDelegate.getAvailableFuture().isDone()).isTrue();
// request one buffer from the local pool to make it unavailable
RecordWriter recordWriter = writerDelegate.getRecordWriter(0);
for (int i = 0; i < memorySegmentSize / recordSize; ++i) {
recordWriter.emit(new IntValue(i));
}
- assertFalse(writerDelegate.isAvailable());
+ assertThat(writerDelegate.isAvailable()).isFalse();
CompletableFuture future = writerDelegate.getAvailableFuture();
- assertFalse(future.isDone());
+ assertThat(future.isDone()).isFalse();
Review Comment:
Thanks for catching this!
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterDelegateTest.java:
##########
@@ -137,17 +134,17 @@ private RecordWriter createRecordWriter(NetworkBufferPool
globalPool) throws Exc
private void verifyAvailability(RecordWriterDelegate writerDelegate)
throws Exception {
// writer is available at the beginning
- assertTrue(writerDelegate.isAvailable());
- assertTrue(writerDelegate.getAvailableFuture().isDone());
+ assertThat(writerDelegate.isAvailable()).isTrue();
+ assertThat(writerDelegate.getAvailableFuture().isDone()).isTrue();
Review Comment:
Thanks for catching this!
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/serialization/EventSerializerTest.java:
##########
@@ -119,50 +116,51 @@ public class EventSerializerTest {
};
@Test
- public void testSerializeDeserializeEvent() throws Exception {
+ void testSerializeDeserializeEvent() throws Exception {
for (AbstractEvent evt : events) {
ByteBuffer serializedEvent =
EventSerializer.toSerializedEvent(evt);
- assertTrue(serializedEvent.hasRemaining());
+ assertThat(serializedEvent.hasRemaining()).isTrue();
AbstractEvent deserialized =
EventSerializer.fromSerializedEvent(
serializedEvent, getClass().getClassLoader());
- assertNotNull(deserialized);
- assertEquals(evt, deserialized);
+ assertThat(deserialized).isNotNull();
+ assertThat(deserialized).isEqualTo(evt);
Review Comment:
Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
