luoyuxia commented on code in PR #23166:
URL: https://github.com/apache/flink/pull/23166#discussion_r1299495861
##########
flink-connectors/flink-sql-connector-hive-3.1.3/pom.xml:
##########
@@ -223,6 +223,10 @@ under the License.
<pattern>org.apache.parquet</pattern>
<shadedPattern>org.apache.hive.shaded.parquet</shadedPattern>
Review Comment:
No, I dont' need we need. Otherwise it'll cause some problems.
See
https://issues.apache.org/jira/browse/FLINK-23074?focusedCommentId=17374459&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17374459
##########
flink-connectors/flink-sql-connector-hive-3.1.3/pom.xml:
##########
@@ -223,6 +223,10 @@ under the License.
<pattern>org.apache.parquet</pattern>
<shadedPattern>org.apache.hive.shaded.parquet</shadedPattern>
</relocation>
+ <relocation>
+
<pattern>shaded.parquet</pattern>
+
<shadedPattern>org.apache.flink.hive.reshaded.parquet</shadedPattern>
Review Comment:
I'm thinking whether it's a good shade pattern in there. it's same to the
shade pattern in connector-hive jar. It may overwride the classes in
connector-hive jar.
How about reshading to `org.apache.hive.reshaded.parquet` like we don in
FLINK-23074?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
