dongwoo6kim commented on code in PR #23166:
URL: https://github.com/apache/flink/pull/23166#discussion_r1299594649
##########
flink-connectors/flink-sql-connector-hive-3.1.3/pom.xml:
##########
@@ -223,6 +223,10 @@ under the License.
<pattern>org.apache.parquet</pattern>
<shadedPattern>org.apache.hive.shaded.parquet</shadedPattern>
</relocation>
+ <relocation>
+
<pattern>shaded.parquet</pattern>
+
<shadedPattern>org.apache.flink.hive.reshaded.parquet</shadedPattern>
Review Comment:
@luoyuxia Thanks for the reply. I've understood that the pattern should be
different from ```connector-hive jar```.
```org.apache.hive.reshaded.parquet``` looks good to me.
However I have one more question about this below part
https://github.com/apache/flink/blob/e01183c8da082b1586dd4eba6ec24f29e6d2fe12/flink-connectors/flink-sql-connector-hive-2.3.9/pom.xml#L114
Don't we need to also change ```flink-sql-connector-hive-2.3.9```, to avoid
overwriding classes from ```connector-hive.jar```?
This part seems to be changed from this
[pr](https://github.com/apache/flink/pull/16012), I'm wondering if you are
aware of this change before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
