X-czh commented on PR #23212: URL: https://github.com/apache/flink/pull/23212#issuecomment-1686614821
Thanks @huwh for the comments. I've updated a new commit that did the following: 1. No longer package `flink-examples-streaming` and `flink-connector-datagen` into a uber-jar, as there are other modules that depend on `flink-examples-streaming` and we don't directly use `flink-examples-streaming` jar as an example jar. 2. Disable reduced dependency pom generation for `flink-example-streaming` as this will reduce dependencies (e.g. `flink-connector-datagen`) included in the shaded jar but required by other modules depending on `flink-examples-streaming` (e.g. `flink-examples-streaming-state-machine`). 3. Fix the wrong filtering setting in the previous commit that mistakenly excludes classes from `flink-connector-kafka`. 4. Remove the Scala version suffix when including `flink-examples-streaming` and `flink-connector-kafka` as they are Scala-free now. Please review again when you are free, much thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
