huwh commented on code in PR #23212:
URL: https://github.com/apache/flink/pull/23212#discussion_r1300832684
##########
flink-examples/flink-examples-build-helper/flink-examples-streaming-state-machine/pom.xml:
##########
@@ -71,15 +71,16 @@ under the License.
</transformers>
<artifactSet>
<includes>
-
<include>org.apache.flink:flink-connector-kafka*</include>
-
<include>org.apache.flink:flink-examples-streaming*</include>
+
<include>org.apache.flink:flink-connector-datagen</include>
+
<include>org.apache.flink:flink-connector-kafka</include>
+
<include>org.apache.flink:flink-examples-streaming</include>
<include>org.apache.kafka:*</include>
</includes>
</artifactSet>
<filters>
<filter>
-
<artifact>org.apache.flink:flink-examples-streaming_*</artifact>
+
<artifact>org.apache.flink:flink-examples-streaming</artifact>
Review Comment:
It's better to split these changes (fix wrong filtering and remove Scala
version) into a hotfix commit at the top of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
