ferenc-csaky commented on code in PR #23211:
URL: https://github.com/apache/flink/pull/23211#discussion_r1300638014
##########
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobKeyTest.java:
##########
@@ -235,8 +228,8 @@ private void testStreams(BlobKey.BlobType blobType) throws
IOException {
* @param key2 second blob key
*/
static void verifyKeyDifferentHashEquals(BlobKey key1, BlobKey key2) {
- assertNotEquals(key1, key2);
- assertThat(key1.getHash(), equalTo(key2.getHash()));
+ assertThat(key1).isNotEqualTo(key2);
+ assertThat(key1.getHash()).isEqualTo(key2.getHash());
Review Comment:
`getHash()` is actually different than `hashCode()`, so the hashcode
shorthand cannot be used for that. Same for the other `getHash()` related
comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
