1996fanrui commented on code in PR #23211:
URL: https://github.com/apache/flink/pull/23211#discussion_r1302917060
##########
flink-runtime/src/test/java/org/apache/flink/runtime/blob/BlobCacheGetTest.java:
##########
@@ -384,59 +355,53 @@ private void testGetFailsStore(@Nullable final JobID
jobId, BlobKey.BlobType blo
* the file. File transfers should fail.
*/
@Test
- public void testGetFailsHaStoreForJobHa() throws IOException {
+ void testGetFailsHaStoreForJobHa() throws IOException {
final JobID jobId = new JobID();
- final Configuration config = new Configuration();
- try (BlobServer server =
- new BlobServer(config, temporaryFolder.newFolder(),
new VoidBlobStore());
- BlobCacheService cache =
- new BlobCacheService(
- config,
- temporaryFolder.newFolder(),
- new VoidBlobStore(),
- new InetSocketAddress("localhost",
server.getPort()))) {
+ Tuple2<BlobServer, BlobCacheService> serverAndCache =
+ TestingBlobUtils.createServerAndCache(tempDir);
+ try (BlobServer server = serverAndCache.f0;
+ BlobCacheService cache = serverAndCache.f1) {
server.start();
// store the data on the server (and blobStore), remove from local
server store
byte[] data = new byte[2000000];
rnd.nextBytes(data);
PermanentBlobKey blobKey = (PermanentBlobKey) put(server, jobId,
data, PERMANENT_BLOB);
- assertTrue(server.getStorageLocation(jobId, blobKey).delete());
+ assertThat(server.getStorageLocation(jobId,
blobKey).delete()).isTrue();
File tempFileDir =
server.createTemporaryFilename().getParentFile();
- // request the file from the server via the cache
- exception.expect(IOException.class);
- exception.expectMessage("Failed to fetch BLOB ");
-
try {
- get(cache, jobId, blobKey);
+ assertThatThrownBy(() -> get(cache, jobId, blobKey))
+ .isInstanceOf(IOException.class)
+ .hasMessageStartingWith("Failed to fetch BLOB");
} finally {
HashSet<String> expectedDirs = new HashSet<>();
expectedDirs.add("incoming");
expectedDirs.add(JOB_DIR_PREFIX + jobId);
// only the incoming and job directory should exist (no job
directory!)
File storageDir = tempFileDir.getParentFile();
String[] actualDirs = storageDir.list();
- assertNotNull(actualDirs);
- assertEquals(expectedDirs, new
HashSet<>(Arrays.asList(actualDirs)));
+ assertThat(actualDirs).isNotNull();
+ assertThat(actualDirs).isNotEmpty();
+
assertThat(actualDirs).containsExactlyInAnyOrderElementsOf(expectedDirs);
Review Comment:
Is this not updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
