wangzzu commented on code in PR #23242:
URL: https://github.com/apache/flink/pull/23242#discussion_r1301146027
##########
flink-runtime/src/test/java/org/apache/flink/runtime/rest/RestClientTest.java:
##########
@@ -151,23 +145,27 @@ public void testConnectionClosedHandling() throws
Exception {
connectionSocket.close();
}
- FlinkAssertions.assertThatFuture(responseFuture)
- .eventuallyFailsWith(ExecutionException.class)
- .withCauseInstanceOf(IOException.class);
+ try {
+ responseFuture.get();
+ } catch (ExecutionException ee) {
+ if (!ExceptionUtils.findThrowable(ee,
IOException.class).isPresent()) {
+ throw ee;
+ }
+ }
Review Comment:
I checked this, I have not changed here, but it would be better to use
`assertThatFuture`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
