lindong28 commented on code in PR #23268:
URL: https://github.com/apache/flink/pull/23268#discussion_r1305052461
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/VertexEndOfDataListener.java:
##########
@@ -47,8 +54,15 @@ public VertexEndOfDataListener(ExecutionGraph
executionGraph) {
}
public void recordTaskEndOfData(ExecutionAttemptID executionAttemptID) {
- BitSet subtaskStatus =
tasksReachedEndOfData.get(executionAttemptID.getJobVertexId());
- subtaskStatus.set(executionAttemptID.getSubtaskIndex());
+ JobVertexID jobVertexId = executionAttemptID.getJobVertexId();
+ if (!tasksReachedEndOfData.containsKey(jobVertexId)) {
+ LOG.warn(
Review Comment:
Can you explain when this can possibly happen? Also, what is the purpose of
adding this warning level logging?
Here is a good summary of the purpose of each logging level.
https://stackoverflow.com/questions/2031163/when-to-use-the-different-log-levels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
