[GitHub] [flink] lindong28 commented on a diff in pull request #23268: [FLINK-32945][runtime] Fix NPE when task reached end-of-data but checkpoint failed

[via GitHub]

lindong28 commented on code in PR #23268:
URL: https://github.com/apache/flink/pull/23268#discussion_r1306838812


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/VertexEndOfDataListener.java:
##########
@@ -23,17 +23,24 @@
 import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
 import org.apache.flink.runtime.jobgraph.JobGraph;
 import org.apache.flink.runtime.jobgraph.JobVertexID;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.BitSet;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.Map;
+import java.util.Set;
 
 /**
  * Records the end of data event of each task, and allows for checking whether 
all tasks of a {@link
  * JobGraph} have reached the end of data.
  */
 public class VertexEndOfDataListener {
+    private static final Logger LOG = 
LoggerFactory.getLogger(VertexEndOfDataListener.class);

Review Comment:
   Do we still need this variable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org