gyfora commented on code in PR #657:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/657#discussion_r1305334236
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -257,7 +259,8 @@ private void updateStatusBeforeFirstDeployment(
* @return True if spec change reconciliation was executed
*/
protected abstract boolean reconcileSpecChange(
- FlinkResourceContext<CR> ctx, Configuration deployConfig) throws
Exception;
+ FlinkResourceContext<CR> ctx, Configuration deployConfig, boolean
requireScale)
Review Comment:
Let's pass the difftype as an argument instead of the confusing boolean
param I think.
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -267,7 +270,8 @@ protected abstract boolean reconcileSpecChange(
* @return True if any further reconciliation action was taken.
* @throws Exception Error during reconciliation.
*/
- protected abstract boolean reconcileOtherChanges(FlinkResourceContext<CR>
ctx) throws Exception;
+ protected abstract boolean reconcileOtherChanges(
+ FlinkResourceContext<CR> ctx, boolean requireScale) throws
Exception;
Review Comment:
Let's pass the difftype as an argument instead of the confusing boolean
param I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
