gyfora commented on code in PR #657:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/657#discussion_r1316788711
##########
flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconcilerTest.java:
##########
@@ -873,6 +891,58 @@ public void cancelJob(
assertEquals(1, rescaleCounter.get());
}
+ @Test
+ public void testScaleWithJobGraphKeptInHAMetadata() throws Exception {
+ final String jobGraphKey = Constants.JOB_GRAPH_STORE_KEY_PREFIX +
JobID.generate();
+ final String jobGraphVal = "job-graph-data";
+ createHAConfigMapWithData(
+ kubernetesClient,
+ "ha-configmap",
+ TEST_NAMESPACE,
+ TEST_DEPLOYMENT_NAME,
+ Collections.singletonMap(jobGraphKey, jobGraphVal));
+ final Map<String, String> configMapLabels =
+ KubernetesUtils.getConfigMapLabels(
+ TEST_DEPLOYMENT_NAME,
Constants.LABEL_CONFIGMAP_TYPE_HIGH_AVAILABILITY);
+ assertEquals(
+ jobGraphVal,
+ kubernetesClient
+ .configMaps()
+ .inNamespace(TEST_NAMESPACE)
+ .withLabels(configMapLabels)
+ .list()
+ .getItems()
+ .get(0)
+ .getData()
+ .get(jobGraphKey));
+
+ FlinkDeployment deployment = TestUtils.buildApplicationCluster();
+ getJobSpec(deployment).setUpgradeMode(UpgradeMode.LAST_STATE);
+ reconciler.reconcile(deployment, context);
+ verifyAndSetRunningJobsToStatus(deployment, flinkService.listJobs());
+ getJobSpec(deployment).setParallelism(100);
+ reconciler.reconcile(deployment, context);
+ assertEquals(JobState.SUSPENDED, getReconciledJobState(deployment));
+
assertFalse(deployment.getStatus().getReconciliationStatus().scalingInProgress());
+ getJobSpec(deployment).setState(JobState.SUSPENDED);
+ deployment
+ .getSpec()
+ .getFlinkConfiguration()
+ .put(PipelineOptions.PARALLELISM_OVERRIDES.key(), new
JobVertexID() + ":1");
+ reconciler.reconcile(deployment, context);
+ assertEquals(
Review Comment:
Could you please add some comments to the test case (step by step) just so
that we can all understand what is being tested/verified in each step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
