Jiabao-Sun commented on code in PR #23233:
URL: https://github.com/apache/flink/pull/23233#discussion_r1306402848
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/sort/ExternalSortLargeRecordsITCase.java:
##########
@@ -402,11 +400,11 @@ public Tuple2<Long, SmallOrMediumOrLargeValue> next() {
for (int i = 0; i < NUM_RECORDS; i++) {
val = iterator.next(val);
- assertTrue(val.f0 <= prevKey);
- assertTrue(val.f0.intValue() == val.f1.val());
+ assertThat(val.f0).isLessThanOrEqualTo(prevKey);
+ assertThat(val.f0.intValue()).isEqualTo(val.f1.val());
Review Comment:
Hi @1996fanrui, I think in this case we can't do that change.
```java
val.f0 = 9096591260535499745L > Integer.MAX_VALUE
val.f1.val = 1059335137L
```
Only the `val.f0.intValue()` can match that assertion.
These test cases test for integer precision, I think maybe we don't need to
change them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
