gyfora commented on code in PR #648:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/648#discussion_r1308206545
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkOperatorConfiguration.java:
##########
@@ -185,6 +186,9 @@ public static FlinkOperatorConfiguration
fromConfiguration(Configuration operato
boolean savepointOnDeletion =
operatorConfig.get(KubernetesOperatorConfigOptions.SAVEPOINT_ON_DELETION);
+ boolean drainJobOnSavepointDeletion =
+
operatorConfig.get(KubernetesOperatorConfigOptions.DRAIN_ON_SAVEPOINT_DELETION);
Review Comment:
Similar to this fix PR:
https://github.com/apache/flink-kubernetes-operator/pull/659
These configs should not be part of the `FlinkOperatorConfiguration` which
will prevent it for setting it for a per-resource level. It should be accessed
from the observeConfig directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
