gyfora commented on code in PR #648:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/648#discussion_r1310286494
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -566,4 +566,12 @@ public static String operatorConfigKey(String key) {
.defaultValue(false)
.withDescription(
"Indicate whether a savepoint must be taken when
deleting a FlinkDeployment or FlinkSessionJob.");
+
+ @Documentation.Section(SECTION_DYNAMIC)
+ public static final ConfigOption<Boolean> DRAIN_ON_SAVEPOINT_DELETION =
+ operatorConfig("job.drain-on-savepoint-deletion")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Indicate whether a job should be drained before
deleting a FlinkDeployment or FlinkSessionJob, only if savepoint on deletion is
enabled.");
Review Comment:
`Indicate whether a job should be drained before deleting a FlinkDeployment
or FlinkSessionJob, only if savepoint on deletion is enabled.` -> `Indicate
whether the job should be drained when stopping with savepoint.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
