gyfora commented on code in PR #664:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/664#discussion_r1315671205
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/JobAutoScaler.java:
##########
@@ -30,6 +28,6 @@ public interface JobAutoScaler {
/** Called when the custom resource is deleted. */
void cleanup(FlinkResourceContext<?> ctx);
- /** Get the current parallelism overrides for the job. */
- Map<String, String> getParallelismOverrides(FlinkResourceContext<?> ctx);
+ /** Apply current parallelism overrides. */
+ void applyParallelismOverrides(FlinkResourceContext<?> ctx);
Review Comment:
This is based on earlier discussion in
https://issues.apache.org/jira/browse/FLINK-32589
Overrides need to be applied separately (and it was implemented already this
way I just relocated the logic) so that we do not lose them on spec changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
