mxm commented on code in PR #664:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/664#discussion_r1315892963
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/JobAutoScaler.java:
##########
@@ -30,6 +28,6 @@ public interface JobAutoScaler {
/** Called when the custom resource is deleted. */
void cleanup(FlinkResourceContext<?> ctx);
- /** Get the current parallelism overrides for the job. */
- Map<String, String> getParallelismOverrides(FlinkResourceContext<?> ctx);
+ /** Apply current parallelism overrides. */
+ void applyParallelismOverrides(FlinkResourceContext<?> ctx);
Review Comment:
I couldn't find any discussion in that thread which would explain why the
overrides couldn't be applied without the method here. Perhaps the code would
need refactoring (which is done here already) to apply the scale method before
reconciling other parts of the spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
