masteryhx commented on code in PR #23364:
URL: https://github.com/apache/flink/pull/23364#discussion_r1318053189
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -141,7 +141,7 @@ public class CheckpointCoordinator {
private final CheckpointStorageCoordinatorView checkpointStorageView;
/** A list of recent checkpoint IDs, to identify late messages (vs invalid
ones). */
Review Comment:
```suggestion
/** A list of recent expired checkpoint IDs, to identify late messages
(vs invalid ones). */
```
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java:
##########
@@ -1164,7 +1164,7 @@ public void receiveDeclineMessage(DeclineCheckpoint
message, String taskManagerL
abortPendingCheckpoint(
checkpoint, checkpointException,
message.getTaskExecutionId());
} else if (LOG.isDebugEnabled()) {
- if (recentPendingCheckpoints.contains(checkpointId)) {
+ if (recentExpiredCheckpoints.contains(checkpointId)) {
// message is for an unknown checkpoint, or comes too late
(checkpoint disposed)
Review Comment:
Could we just say "message is for an expired checkpoint" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
