echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1321387884
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java:
##########
@@ -47,6 +51,10 @@
class Executing extends StateWithExecutionGraph implements ResourceListener {
private final Context context;
+ private Instant lastRescale = Instant.EPOCH;
Review Comment:
I agree, there is indeed a bug in Executing being a new object with each
rescale when the transition to Restaring and then to Executing state is done. I
thought the state of the Executing object was kept between the restarts (with
checkpointing) but it is not, a new one is created in the transitionToState().
This leeds to lastRescale being always be EPOCH. Thanks for pointing out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
