pnowojski commented on code in PR #23391:
URL: https://github.com/apache/flink/pull/23391#discussion_r1322727310
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointStatsTracker.java:
##########
@@ -227,11 +257,23 @@ void reportFailedCheckpoint(FailedCheckpointStats failed)
{
history.replacePendingCheckpointById(failed);
dirty = true;
+ logCheckpointStatistics(failed);
} finally {
statsReadWriteLock.unlock();
}
}
+ private void logCheckpointStatistics(AbstractCheckpointStats
checkpointStats) {
+ try {
+ StringWriter sw = new StringWriter();
+ MAPPER.writeValue(sw,
CheckpointStatistics.generateCheckpointStatistics(checkpointStats, true));
+ String jsonDump = sw.toString();
Review Comment:
I was thinking about that, decided against complicating this line, as this
method is called very rarely. But in the end sure, why not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
