ferenc-csaky commented on code in PR #23469:
URL: https://github.com/apache/flink/pull/23469#discussion_r1341880718
##########
pom.xml:
##########
@@ -1764,8 +1768,7 @@ under the License.
<configuration>
<rules>
<requireMavenVersion>
- <!--
enforce at least mvn version 3.1.1 (see FLINK-12447) -->
-
<version>[3.1.1,)</version>
+
<version>${minimum.maven.version}</version>
Review Comment:
Although the given version here is converted implicitly to an open ended
range, I'd keep the range syntax explicitly as it was
(`[${minimum.maven.version},)`), so it is more obvious.
##########
pom.xml:
##########
@@ -1334,7 +1338,7 @@ under the License.
</property>
</activation>
<properties>
- <target.java.version>1.8</target.java.version>
+
<target.java.version>${target.java.version}</target.java.version>
Review Comment:
I believe this is unnecessary and the whole `properties` tag can be removed,
cause it is enough if the prop is defined in the root property scope, by
default it will be inherited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
