davidradl commented on code in PR #23469:
URL: https://github.com/apache/flink/pull/23469#discussion_r1347443841


##########
pom.xml:
##########
@@ -1334,7 +1338,7 @@ under the License.
                                </property>
                        </activation>
                        <properties>
-                               <target.java.version>1.8</target.java.version>
+                               
<target.java.version>${target.java.version}</target.java.version>

Review Comment:
   Good point!



##########
pom.xml:
##########
@@ -1764,8 +1768,7 @@ under the License.
                                                <configuration>
                                                        <rules>
                                                                
<requireMavenVersion>
-                                                                       <!-- 
enforce at least mvn version 3.1.1 (see FLINK-12447) -->
-                                                                       
<version>[3.1.1,)</version>
+                                                                       
<version>${minimum.maven.version}</version>

Review Comment:
   ok I will change 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to