Vlado Vojdanovski created FLINK-33189:
-----------------------------------------
Summary:
FsCompletedCheckpointStorageLocation#disposeStorageLocation non-recursively
deletes a directory
Key: FLINK-33189
URL: https://issues.apache.org/jira/browse/FLINK-33189
Project: Flink
Issue Type: Bug
Components: Runtime / Checkpointing
Reporter: Vlado Vojdanovski
FsCompletedCheckpointStorageLocation attempts to non-recursively delete a
directory
[https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCompletedCheckpointStorageLocation.java#L74]
However, per the documentation of Flink's FileSystem Interface, such attempts
are supposed to fail.
" * @param recursive if path is a directory and set to <code>true</code>, the
directory is
* deleted else throws an exception. In case of a file the recursive
can be set to either
* <code>true</code> or <code>false</code> "
[https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java#L689]
I am sure there is a non-negligible chance I am missing some flink internals
here considering the class has not been touched since 2018 but my read is the
above is either a bug, or it would be nice to update the FileSystem#delete docs.
Thanks for taking a look :) !
--
This message was sent by Atlassian Jira
(v8.20.10#820010)