surendralilhore commented on code in PR #23428:
URL: https://github.com/apache/flink/pull/23428#discussion_r1346878450
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/utils/JarHandlerUtils.java:
##########
@@ -189,7 +189,11 @@ public PackagedProgram toPackagedProgram(Configuration
configuration) {
.setArguments(programArgs.toArray(new String[0]))
.build();
} catch (final ProgramInvocationException e) {
- throw new CompletionException(e);
+ throw new CompletionException(
Review Comment:
Thanks @XComp for review.
We have a tool that uses a REST API to submit jobs, but if the user provides
the wrong entry class name by mistake, Flink returns an INTERNAL_SERVER_ERROR,
which can be confusing.
You bring up a valid concern regarding exceptions like those thrown by
`PackagedProgram#extractContainedLibrarie`s, which might be related to internal
issues. To address this, we should consider improving our error handling to
distinguish between user-provided errors and internal issues. This way, we can
ensure that our responses accurately reflect the nature of the problem and
provide better feedback to our users.
I will try to find a better solution for this. Do you have any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
