XComp commented on code in PR #23428:
URL: https://github.com/apache/flink/pull/23428#discussion_r1346884026
##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/utils/JarHandlerUtils.java:
##########
@@ -189,7 +189,11 @@ public PackagedProgram toPackagedProgram(Configuration
configuration) {
.setArguments(programArgs.toArray(new String[0]))
.build();
} catch (final ProgramInvocationException e) {
- throw new CompletionException(e);
+ throw new CompletionException(
Review Comment:
> We have a tool that uses a REST API to submit jobs, but if the user
provides the wrong entry class name by mistake, Flink returns an
INTERNAL_SERVER_ERROR, which can be confusing.
I'm not questioning your intention. I just want to point out that the
approach you follow might not be sufficient. The error handling of the job
submission is not that concise. It requires a bigger effort to make this right
in my opinion.
I'm happy to help if you're interested in addressing this issue on a broader
angle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
