1996fanrui commented on PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#issuecomment-1752467497
> The refactor also completely changes how the autoscaler module is loaded in the operator. Previously we intentionally loaded this as a service so it would be possible to potentially upgrade the autoscaler without the rest of the operator. > > Now @1996fanrui you moved the operator related autoscaler classes in the main operator module resulting in a tight coupling. > > @mxm how do you feel about this? Originally you were the one who introduced the service loader approach :) Sorry for breaking this due to I don't know the background before. And thanks to @gyfora for pointing it out. If it's still needed, I can restore the `flink-kubernetes-operator-autoscaler` module. And moving all kubernetes-autoscaler related classes to this module. WDYT? cc @mxm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
