1996fanrui commented on code in PR #677:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1354332455
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -174,6 +182,32 @@ public void reconcile(FlinkResourceContext<CR> ctx) throws
Exception {
}
}
+ private void scaling(FlinkResourceContext<CR> ctx) throws Exception {
+ KubernetesJobAutoScalerContext autoScalerContext =
ctx.getJobAutoScalerContext();
+
+ if (autoscalerDisabled(ctx)) {
+ autoScalerContext.getConfiguration().set(AUTOSCALER_ENABLED,
false);
+ resourceScaler.scale(autoScalerContext);
+ return;
+ }
+ if (waitingForRunning(ctx.getResource().getStatus())) {
+ LOG.info("Autoscaler is waiting for stable, running state");
+ resourceScaler.cleanup(autoScalerContext.getJobKey());
+ return;
Review Comment:
Thanks to @mxm for the suggestion!
I have moved the `waitingForRunning` logic back to autoscaler module, and
related tests have been recovered.
Also, these 2 comments[1][2] have been recovered as well.
[1]
https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1350082356
[2]
https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1350079573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
