KarmaGYZ commented on code in PR #23513:
URL: https://github.com/apache/flink/pull/23513#discussion_r1355969956
##########
flink-test-utils-parent/flink-test-utils/pom.xml:
##########
@@ -163,6 +163,17 @@ under the License.
<scope>runtime</scope>
</dependency>
+ <!-- This dependency is added for `flink-benchmarks` project
which will
+ use zookeeper testing server to benchmark olap performance.
This dependency
+ is added here to ensure that its version is consistent with the
flink
+ version in the `flink-benchmarks` and to avoid conflicts.
Removing this
+ dependency may cause failure of `flink-benchmarks`. -->
+ <dependency>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-test</artifactId>
+ <version>${curator.version}</version>
+ </dependency>
+
Review Comment:
As discussed in https://github.com/apache/flink-benchmarks/pull/78,
> We might want to add a comment to the corresponding line in
[apache/flink:pom.xml:144](https://github.com/apache/flink/blob/ec6ebe2d22d15883f7236895387a45a533cfefe0/pom.xml#L144)
to point out that updating the curator version in Flink should result in
updating the corresponding version in Flink's benchmark tests as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
