FangYongs commented on code in PR #23513:
URL: https://github.com/apache/flink/pull/23513#discussion_r1356001155
##########
flink-test-utils-parent/flink-test-utils/pom.xml:
##########
@@ -163,6 +163,17 @@ under the License.
<scope>runtime</scope>
</dependency>
+ <!-- This dependency is added for `flink-benchmarks` project
which will
+ use zookeeper testing server to benchmark olap performance.
This dependency
+ is added here to ensure that its version is consistent with the
flink
+ version in the `flink-benchmarks` and to avoid conflicts.
Removing this
+ dependency may cause failure of `flink-benchmarks`. -->
+ <dependency>
+ <groupId>org.apache.curator</groupId>
+ <artifactId>curator-test</artifactId>
+ <version>${curator.version}</version>
+ </dependency>
+
Review Comment:
We don't need to add corator-test dependency in flink-benchmark after adding
it here, so we may not need to add comment in
[apache/flink:pom.xml:144](https://github.com/apache/flink/blob/ec6ebe2d22d15883f7236895387a45a533cfefe0/pom.xml#L144).
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
