XComp commented on code in PR #677:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1356512684
##########
flink-autoscaler/pom.xml:
##########
@@ -45,6 +45,32 @@ under the License.
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
+ <version>${lombok.version}</version>
+ <scope>provided</scope>
+ </dependency>
+
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-params</artifactId>
+ <scope>test</scope>
+ </dependency>
+
+ <!-- TODO FLINK-33098: These jackson dependencies can be replaced with
flink shaded jackson. It can be done
Review Comment:
There's gonna be another release candidate (RC2) by the end of the week
according to the release managers. I hope that 1.18.0 will be released within
October.
Using the shaded jackson dependency from Flink (in contrast to shading the
dependency within the Kubernetes operator) comes with the benefit that you
don't have to maintain a dedicated entry in the NOTICE file, as far as I
understand. So, it has "some advantage".
Anyway, the approach can be changed later on if it becomes a problem. So,
feel free to follow what you agreed on in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
