mateczagany commented on code in PR #677:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1360856610
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java:
##########
@@ -441,15 +442,21 @@ protected Collection<AggregatedMetric>
queryAggregatedMetricNames(
protected abstract Map<JobVertexID, Map<FlinkMetric, AggregatedMetric>>
queryAllAggregatedMetrics(
- AbstractFlinkResource<?, ?> cr,
- FlinkService flinkService,
- Configuration conf,
+ Context ctx,
Map<JobVertexID, Map<String, FlinkMetric>>
filteredVertexMetricNames);
- public void cleanup(AbstractFlinkResource<?, ?> cr) {
- var resourceId = ResourceID.fromResource(cr);
- histories.remove(resourceId);
- availableVertexMetricNames.remove(resourceId);
+ public JobDetailsInfo getJobDetailsInfo(
+ JobAutoScalerContext<KEY> context, Duration clientTimeout) throws
Exception {
Review Comment:
That makes sense, I think you've explained it very well, thank you!
I still think that the naming and the abstraction can be a bit confusing for
a fresh pair of eyes, but as you've said and as I've said in my original
comment, this is not related to your PR, so I think it's perfectly fine to
leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
