1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1356642732
##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -488,6 +488,23 @@ public enum SchedulerType {
code(SchedulerExecutionMode.REACTIVE.name()))
.build());
+ @Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)
+ public static final ConfigOption<Duration> SCHEDULER_SCALING_INTERVAL_MIN =
+ key("jobmanager.adaptive-scheduler.scaling-interval.min")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(30))
+ // rescaling and let the user increase the value for high
workloads
+ .withDescription(
+ "Determines the minimum time (in seconds) between
scaling operations in reactive mode.");
Review Comment:
I guess the min and max parameters take effect when adaptive scheduler is
enabled with the rest api of FLIP-291.
Because I don't see any logic that they're just enabled when reactive mode
is activated. And these code is placed at adaptive scheduler, so I guess they
take effect once adaptive scheduler is enabled.
Or you can try it locally, enable adaptive scheduler without reactive mode,
and rescale it with the rescale button of FLIP-291 in Flink WebUI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
