echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1358336728
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##########
@@ -570,8 +659,9 @@ public void setHowToHandleFailure(Function<Throwable,
FailureResult> function) {
this.howToHandleFailure = function;
}
- public void setCanScaleUp(Supplier<Boolean> supplier) {
- this.canScaleUp = supplier;
+ public void setCanScaleUp(Boolean minIncreaseMet, Boolean
parallelismChangeAfterTimeout) {
+ this.minIncreaseMet = minIncreaseMet;
+ this.parallelismChangeAfterTimeout = parallelismChangeAfterTimeout;
Review Comment:
Agree for the renaming. But regarding the setters I disagree because the 2
parameters are always set together: it is their combination that gives the
output of the test. I find it way clearer to set them together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
