Zakelly commented on code in PR #79:
URL: https://github.com/apache/flink-benchmarks/pull/79#discussion_r1357891702
##########
src/main/java/org/apache/flink/state/benchmark/RescalingBenchmarkBase.java:
##########
@@ -57,6 +63,26 @@ public static void runBenchmark(Class<?> clazz) throws
RunnerException {
new Runner(options).run();
}
+ protected static File prepareDirectory(String prefix) throws IOException {
Review Comment:
Hi @masteryhx , The `StateBackendBenchmarkUtils` belongs to the Flink repo
and the `prepareDirectory` is a private method. I'd rather not change the Flink
repo for the benchmark needs, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
