[ 
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643804#comment-15643804
 ] 

ASF GitHub Bot commented on FLINK-4282:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2355#discussion_r86749516
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/TimeWindow.java
 ---
    @@ -236,6 +236,6 @@ public int compare(TimeWindow o1, TimeWindow o2) {
         * @return window start
         */
        public static long getWindowStartWithOffset(long timestamp, long 
offset, long windowSize) {
    --- End diff --
    
    In case of sliding windows we have to pass the slide here, yes.


> Add Offset Parameter to WindowAssigners
> ---------------------------------------
>
>                 Key: FLINK-4282
>                 URL: https://issues.apache.org/jira/browse/FLINK-4282
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Aljoscha Krettek
>             Fix For: 1.2.0
>
>
> Currently, windows are always aligned to EPOCH, which basically means days 
> are aligned with GMT. This is somewhat problematic for people living in 
> different timezones.
> And offset parameter would allow to adapt the window assigner to the timezone.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to