pvary opened a new pull request, #23541:
URL: https://github.com/apache/flink/pull/23541
## What is the purpose of the change
Creating direct test for SinkV2
## Brief change log
- Created TestSinkV2 which instantiates a SinkV2 directly
- Refactored tests where we want to keep both V1 and V2 test parallel to
have a base class:
- SinkTransformationTranslatorITCaseBase
- CommitterOperatorTestBase
- SinkWriterOperatorTestBase
- Created new tests where it did not worth to create the base test case:
- SinkV2ITCase
- SinkV2MetricsITCase
- Moved the new tests to use TestSinkV2 where we do not want duplicated
tests:
- DataStreamSinkTest
As a bit unrelated change moved the `InternalSinkWriterMetricGroup.mock`
methods a `MetricsGroupTestUtils` class, so we do not mix test and production
code
## Verifying this change
This is a test change, so the CI will tell if it is correct, or not.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
