[
https://issues.apache.org/jira/browse/FLINK-33287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776993#comment-17776993
]
Rui Fan commented on FLINK-33287:
---------------------------------
Thanks [~martijnvisser] for this comment!
{quote}We're decoupling flink-shaded from all other Flink repos, like
connectors{quote}
May I know why decoupling flink-shaded from connectors? As I understand, it's
because we want the same connector version to support different versions of
Flink, right?
If yes, it's reasonable for connectors.
Let me explain why we prefer flink-autoscaler uses the flink shaded jackson:
* flink-autoscaler only depends on the latest version of flink, it will not
depends on older versions of flink.
* flink-autoscaler is using the jackson version of operator for now, this
version isn't shaded.
* Both non-shaded and shaded versions are fine so now.
* flink-autoscaler has been decoupled from the kubernetes operator and may be
moved to a separate repo in the future. So depending on kubernetes operator
jackson may not be a good choice.
* Currently flink-autoscaler only depends on the latest flink, so there will be
no conflicts with other shaded jackson.
* The shaded version is enough for now, so we prefer bundle it with the flink
client. And we can re-shade it if it doesn't work well in the future.
WDYT?
Please refer to
[comment|https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1336571925]
for more background and details.
> Using the flink shaded jackson for flink-autoscaler
> ---------------------------------------------------
>
> Key: FLINK-33287
> URL: https://issues.apache.org/jira/browse/FLINK-33287
> Project: Flink
> Issue Type: Sub-task
> Components: Autoscaler
> Reporter: Rui Fan
> Assignee: Rui Fan
> Priority: Major
>
> FLINK-33098 still using the jackson version of {{flink-kubernetes-operator}}
> instead of flink shaded version. I want to update it after {{flink-1.18}}
> released.
> The reason is : current autoscaler is using the {{loaderOptions}} to limit
> the serialized size.
> * The shaded jackson version of {{flink-1.17}} is {{{}2.13.4-16.1{}}}, it
> doesn't support the {{{}loaderOptions{}}}.
> * The shaded jackson version of {{flink-1.18}} is {{{}2.14.2-17.0{}}}, it
> supports the {{{}loaderOptions{}}}.
>
> For details can be get from this comment[1].
>
> [1]
> https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1336571925
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
