mxm commented on code in PR #686:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1365734089
##########
flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java:
##########
@@ -151,6 +151,31 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.withDescription(
"Lag threshold which will prevent unnecessary
scalings while removing the pending messages responsible for the lag.");
+ public static final ConfigOption<Duration> OBSERVE_TPR_LAG_THRESHOLD =
+ autoScalerConfig("observed-tpr.lag-threshold")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(30))
+
.withDeprecatedKeys(deprecatedOperatorConfigKey("observed-tpr.lag-threshold"))
+ .withDescription("Lag threshold for enabling observed tpr
measurements.");
Review Comment:
Can we spell out tpr (true processing rate)? I would also prefer that in the
config key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
