gyfora commented on PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#issuecomment-1771237467
> I don't know why we would start collecting already in the stabilization period. That breaks the contract we have established. We can already collect metrics during the window built-up period and we can use those for observed rate measurements. Unless there is a fundamental reason, I would like to not alter ScalingMetricCollector. The reason I changed this is that we rely on lag/catching up job to be able to collect the observed metrics. Many jobs may already catch up during stabilisation period practically rendering the new functionality useless because the observed metric will never be collected. This change doesn't actually affect any other metrics / contract that we have established so far. Everything would be evaluated exactly the same way except the newly added observed metric. But by nature I think that makes sense to collect during stabilisation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
